Manual · Engineering

Engineering record — internal detail. The manual is authoritative for product behaviour.

Engineering2026-08-066 min read

Operations & fleet security review

Fourteen findings across trips, vehicles, drivers, advances, expenses and settlements, with fix designs F1–F7.

ForEngineer

Findings

ClassExamples
Cross-org write and IDORTrip, vehicle, driver and settlement lookups that were not organisation-first
PerformanceMissing indexes on hot filter columns
CacheInvalidation gaps after mutations
AuditMutations not captured in the audit log
AuthorisationRole gates looser than the intended matrix
LintAssorted static issues

The plan records fourteen findings (O1–O14), each paired with a fix task, a test task and a verification command, plus a migration adding new indexes, a post-pass role matrix and a deferred list.

Fix themes

  • Organisation-first getters so a cross-org id cannot resolve.
  • Add the missing indexes before the module goes to production load.
  • Invalidate by pattern after mutation, not by a hand-listed key set.
  • Tighten role gates to the recorded matrix and add audit entries for the operations that were invisible.

Source records

Design
docs/superpowers/specs/2026-08-06-operations-security-review-design.md
Plan
docs/superpowers/plans/2026-08-06-operations-security-review-plan.md